Skip to content

Conversation

@steaks
Copy link
Contributor

@steaks steaks commented Oct 21, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fixes #811. This PR fixes compilation for on Typescript 4.6.3. It still works on 4.9.

I tried the simplest solution - casting the variable to the known type.

References

Include any links supporting this change such as a:

-#811

  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

  1. Change typescript version to 4.6.3 in package.json
  2. Change moduleResolution to node in tsconfig.json
  3. npm install (may need to clean first)
  4. npx tsc -b
  5. See no compilation errors

Developed on Ubuntu 22.04.5 LTS. Tested in Chrome 129.0.6668.58 (Official Build) (64-bit). Tested in Firefox 131.0.3 (64-bit).

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@steaks steaks requested a review from a team as a code owner October 21, 2024 02:54
@steaks
Copy link
Contributor Author

steaks commented Nov 18, 2024

Hey Auth0 team. It's been a month since I created this PR. I'm not sure what to do here. Should I close this PR or reach out to someone for a review?

@gyaneshgouraw-okta gyaneshgouraw-okta force-pushed the fix-typescript-4.6.3-compilation branch from 99bfca9 to 08fa7af Compare September 17, 2025 16:22
@gyaneshgouraw-okta gyaneshgouraw-okta force-pushed the fix-typescript-4.6.3-compilation branch from 08fa7af to b1278e3 Compare September 17, 2025 16:45
gyaneshgouraw-okta added a commit that referenced this pull request Sep 17, 2025
Duplicates PR #812 to  run scans and resolve commit sign issue.

---------

Signed-off-by: Frederik Prijck <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Steven Wexler <[email protected]>
Co-authored-by: KunalOfficial <[email protected]>
Co-authored-by: Lee Freeman <[email protected]>
Co-authored-by: Tushar Pandey <[email protected]>
Co-authored-by: Tushar Pandey <[email protected]>
Co-authored-by: Frederik Prijck <[email protected]>
Co-authored-by: Arpit Jain <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kunal Dawar <[email protected]>
Co-authored-by: Subhankar Maiti <[email protected]>
Co-authored-by: martinml <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
@gyaneshgouraw-okta
Copy link
Contributor

Closing this as duplicate PR has been merged #896 , which had commits signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript compilation error

2 participants